Add recurse_submodules to git clone #648
Conversation
Without cloning submodules, build process as outlined fails. Amend README to add `recurse_submodules` to `git clone`.
|
I just mentioned in #647 (comment) that I created a hard requirement on the llvm-project submodule in #520 which did not previously exist. I want to go modify the |
Seems like the best course of action would be to make changes in |
|
Yes there does seem to be a need for a change in the README related to this in #647 but I also need to open a new PR which resolves the fact that I added an unnecessary dependency. |
| done this before, you may be prompted to elevate. | ||
| 7. Open Visual Studio, and choose the "Clone or check out code" option. Enter the URL to this | ||
| repository, typically `https://github.com/microsoft/STL` | ||
| repository, typically `https://github.com/microsoft/STL`. Make sure that submodules are also checked out. |
There was a problem hiding this comment.
Is there a checkbox or something for this? If not we need an extra step that explains how to do that.
| 6. Open an "x64 Native Tools Command Prompt for VS 2019". | ||
| 7. Change directories to a location where you'd like a clone of this STL repository. | ||
| 8. Invoke `git clone https://github.com/microsoft/STL` | ||
| 8. Invoke `git clone --recurse-submodules https://github.com/microsoft/STL` |
There was a problem hiding this comment.
I think this should have only the instructions for the submodule necessary to build since bringing in this vcpkg copy might not be relevant for folks with an ambient vcpkg available
|
@BillyONeal - based on the thread with @cbezault above, I will pause this PR and follow #647 . If everything is captured in #647 or follow-up PRs, I will close this PR. Thanks for looking at it. |
|
I think #647 will address everything this PR is trying to address. |
|
Thanks @cbezault. Closing the PR. |
3 participants
Without cloning submodules, build process as outlined fails. Amend README to add
recurse_submodulestogit clone.Description
Checklist
Be sure you've read README.md and understand the scope of this repo.
If you're unsure about a box, leave it unchecked. A maintainer will help you.
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before automated testing is enabled on GitHub,
leave this unchecked for initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft (including any cited standards), other WG21 papers
(excluding reference implementations outside of proposed standard wording),
and LWG issues as reference material. If they were derived from a project
that's already listed in NOTICE.txt, that's fine, but please mention it.
If they were derived from any other project (including Boost and libc++,
which are not yet listed in NOTICE.txt), you must mention it here,
so we can determine whether the license is compatible and what else needs
to be done.