Replace __pragma with _Pragma (microsoft#662) #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net> Co-authored-by: Casey Carter <cartec69@gmail.com>
* Add constexpr to array comparison functions + change feature test macro. * Fixed clang-format on array and moved comment in yvals_core.h * Corrected feature test macro constant * Removed libcxx test skip * Added constexpr testing for array comparison operators * clang-formatted the test file * Added CXX20 feature test macro * Fixed 0 size array initialization in test file. * Test variables made global and const, removed to_array, fix typo * clang-format test file * Fixed typo, duplicate line and alignment in the constexpr operator test. * clang-format array * Changed const global variables to constexpr in test file. * Removed double parenthesis in test file. Co-Authored-By: Stephan T. Lavavej <stl@nuwen.net> * Update tests/std/tests/P1023R0_constexpr_for_array_comparisons/test.cpp Co-Authored-By: Stephan T. Lavavej <stl@nuwen.net> * STL's suggestion to avoid disabling clang-format and shorten test. * clang-format 10 array * Removed test skip from expected_results.txt to match skipped_tests.txt Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
#650) Co-authored-by: Sumit Bhardwaj <subhardw@microsoft.com>
In a future release of MSVC, the compiler warns with C4648 on uses of `[[no_unique_address]]`, which the compiler recognizes but does not yet implement. Since `<algorithm>` intentionally uses the attribute, disable the warning in STL headers. This mirrors changes in internal MSVC-PR-239026.
Remove out of date parts of the pull request template, and put instructions to pull request submitters in a comment rather than duplicating them into each PR.
* Replace __pragma with _Pragma VS 2019 16.6 Preview 2 now supports Standard _Pragma. * Fix formatting * _Pragma takes a string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Be sure you've read README.md and understand the scope of this repo.
If you're unsure about a box, leave it unchecked. A maintainer will help you.
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before automated testing is enabled on GitHub,
leave this unchecked for initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft (including any cited standards), other WG21 papers
(excluding reference implementations outside of proposed standard wording),
and LWG issues as reference material. If they were derived from a project
that's already listed in NOTICE.txt, that's fine, but please mention it.
If they were derived from any other project (including Boost and libc++,
which are not yet listed in NOTICE.txt), you must mention it here,
so we can determine whether the license is compatible and what else needs
to be done.