-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Let's rewrite the test harness #1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix tpyos
We correctly deprecated `atomic_init` when implementing P0883R2, but missed that the effects changed as well.
|
@rpjohnst If you could make sure I didn't break your edg_drop machinery that would be much appreciated. |
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
|
I encountered one test failure because my repo root, Same for x64: This doesn't change our |
CaseyCarter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm totally breaking @StephanTLavavej's 17-attack PR merge combo. 🐼
Co-authored-by: Casey Carter <cartec69@gmail.com>
Co-authored-by: Casey Carter <cartec69@gmail.com>
Co-authored-by: Casey Carter <cartec69@gmail.com>
Co-authored-by: Casey Carter <cartec69@gmail.com>
CaseyCarter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now!
|
Thanks for this overhaul, improving test performance! This will both increase maintainer/contributor productivity 🚀 and decrease our costs 🤑. |
This change is mostly cleanups, though it brings us more in line with libcxx's testing format in terms of style and functionality.
I also tried to decrease the size of the
TestConfigandSTLTestobjects as much as possible since those are pickled and communicated to the worker processes via IPC. On my machine I saw a ~20% decrease in testing time with this change (~75mins to ~60mins), we'll see if that holds true on the test machines.