Skip to content

Tests using /analyze:only should also use /analyze:autolog- #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 3 commits into from
Nov 14, 2020
Merged

Tests using /analyze:only should also use /analyze:autolog- #1434

StephanTLavavej merged 3 commits into from
Nov 14, 2020

Conversation

@Arzaghi
Copy link
Contributor

@Arzaghi Arzaghi commented Nov 7, 2020

Closes #1416

@Arzaghi Arzaghi requested a review from a team as a code owner November 7, 2020 20:31
@Arzaghi
Copy link
Contributor Author

Arzaghi commented Nov 7, 2020 •
edited
Loading

I'm wondering why does the pipeline circling at the code format validation stage for over an hour!

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 7, 2020

Commenter does not have sufficient privileges for PR 1434 in repo microsoft/STL

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 7, 2020

Commenter does not have sufficient privileges for PR 1434 in repo microsoft/STL

@StephanTLavavej StephanTLavavej added the test Related to test code label Nov 8, 2020
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Nov 8, 2020

The tests seem to have passed now - but I don't know why they appeared to have stalled, or why the Azure Pipelines bot said you didn't have sufficient privileges - we haven't changed anything recently.

@Arzaghi
Copy link
Contributor Author

Arzaghi commented Nov 8, 2020 •
edited
Loading

The tests seem to have passed now - but I don't know why they appeared to have stalled, or why the Azure Pipelines bot said you didn't have sufficient privileges - we haven't changed anything recently.

The bot said that because I tried to re-trigger the pipeline manually in comments and then I edited my comment.
I pushed other commits and after that everything worked as expected.

@StephanTLavavej StephanTLavavej self-assigned this Nov 13, 2020
@StephanTLavavej StephanTLavavej merged commit 9145bf4 into microsoft:master Nov 14, 2020
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Nov 14, 2020

Thanks for improving the test harness and reducing the amount of output that it writes to the disk! 😸

@Arzaghi Arzaghi deleted the Fix_Issue1416 branch November 14, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@cbezault cbezault cbezault approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

test Related to test code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tests using /analyze:only should also use /analyze:autolog-

4 participants

@Arzaghi @StephanTLavavej @CaseyCarter @cbezault