Skip to content

Implement ranges::join_view #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CaseyCarter merged 56 commits into from
Mar 18, 2021
Merged

Implement ranges::join_view #1436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
92bf126
Implement ranges::join_view
miscco Oct 31, 2020
6766d6b
Reorder: counted & common are after join and before reverse
CaseyCarter Jan 25, 2021
f7d4521
Fix indentation; LWG issue is 3500
CaseyCarter Jan 25, 2021
2716fb4
More formatting cleanup
CaseyCarter Jan 26, 2021
e3e11db
Make deduction guide explicit
CaseyCarter Jan 26, 2021
d4463ac
Add some more wishful [[no_unique_address]] comments
CaseyCarter Jan 26, 2021
e131afc
Nitpicky formatting
CaseyCarter Jan 26, 2021
55cf9e8
Coalesce operator++(int) overloads
CaseyCarter Jan 26, 2021
edc0d76
ranges:: -> _RANGES
CaseyCarter Jan 26, 2021
14fbe65
I've submitted an LWG issue to constrain join_view::iterator's iter_swap
CaseyCarter Jan 27, 2021
cd6793a
Cleanup noexcept in join_view::sentinel
CaseyCarter Jan 28, 2021
7b20bf0
join_view only has _Inner when !_Deref_is_ref
CaseyCarter Jan 28, 2021
13a5b7e
LWG-3517 is numbered
CaseyCarter Feb 1, 2021
5c54a90
common_type => common_type_t
CaseyCarter Feb 1, 2021
07d8158
Fix return types of post-xcrement operators
CaseyCarter Feb 1, 2021
ecaf90b
Suppress Clang "unused capture" wanring
CaseyCarter Feb 1, 2021
ab42d29
Use the preprocessor to disable portions of test.cpp instead of `/* .…
CaseyCarter Feb 1, 2021
745f363
Remove `pipeline` from test; we've got enough tests of the pipelining…
CaseyCarter Feb 1, 2021
212e343
Wiggle
CaseyCarter Feb 1, 2021
f6c3711
Rename _Deref_is_ref to _Deref_is_glvalue
CaseyCarter Feb 2, 2021
b07eed9
Expose more test surface
CaseyCarter Feb 2, 2021
f7fabee
Cleanup definition of `intervals`
CaseyCarter Feb 2, 2021
c2412a1
joind => joined
CaseyCarter Feb 3, 2021
6fc264e
Implement sentinel comparison
CaseyCarter Feb 11, 2021
766f3c1
test WIP
CaseyCarter Feb 11, 2021
8a550ef
Don't reuse inner ranges in the move-only view test
CaseyCarter Feb 11, 2021
58c24d2
more test WIP
CaseyCarter Feb 12, 2021
c1693b2
Use _Join_view_base
miscco Feb 20, 2021
7b9a177
Enable join_view::end tests
miscco Feb 20, 2021
39f8254
join_view is not random access so nodata and operator[]
miscco Feb 20, 2021
1524233
WIP join_view::front
miscco Feb 20, 2021
15c42b0
Add join_view::front and join_view::back
miscco Feb 20, 2021
38911fa
Start testing view_interface::base
miscco Feb 20, 2021
c30fd91
Merge branch 'main' into join_view
miscco Mar 5, 2021
50949de
Fix the tests a bit
miscco Mar 5, 2021
0a50113
Try enable more of the base checks
miscco Mar 5, 2021
9627511
Don't assume that we can construct a value_type from a reference_type
CaseyCarter Mar 9, 2021
bd5e119
Finish tests for base()
miscco Mar 12, 2021
fe32261
Add tests for different types of containers
miscco Mar 12, 2021
e8dc570
Fix some formatting
miscco Mar 13, 2021
d94ba34
Remove std:: in test
miscco Mar 13, 2021
005fed2
Address review comments from STL
miscco Mar 13, 2021
198e456
Remove incorect noexcept specifications
miscco Mar 13, 2021
3f264c2
Remove redundant begin/end checks (no caching)
CaseyCarter Mar 15, 2021
49a06c0
Add trailing empty interval
CaseyCarter Mar 15, 2021
e8179e6
Avoid unreduced MSVC bug
CaseyCarter Mar 15, 2021
50c4293
Remove extraneous copypasta braces
CaseyCarter Mar 16, 2021
ac546dc
Fix Standard defect in iterator_{category,concept}
CaseyCarter Mar 16, 2021
9469292
Hack test machinery for prvalue reference types
CaseyCarter Mar 16, 2021
b28eece
Complete test overhaul
CaseyCarter Mar 16, 2021
39ecceb
a few fixes:
CaseyCarter Mar 16, 2021
072d985
Add test case with example from LWG-3474
CaseyCarter Mar 16, 2021
ba8ccd9
Drive-by replace `ranges::` with `_RANGES `
CaseyCarter Mar 16, 2021
6b2334b
All outstanding review comments
CaseyCarter Mar 16, 2021
3bc8db8
Apply suggestions from code review
CaseyCarter Mar 17, 2021
78d1ac9
Update tests/std/include/range_algorithm_support.hpp
CaseyCarter Mar 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading