Skip to content

Implement ranges::join_view #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CaseyCarter merged 56 commits into from
Mar 18, 2021
Merged

Implement ranges::join_view #1436

CaseyCarter merged 56 commits into from
Mar 18, 2021

Conversation

@miscco
Copy link
Contributor

@miscco miscco commented Nov 8, 2020 •
edited by CaseyCarter
Loading

Implements the resolutions of LWG-3448, LWG-3474, LWG-3500, LWG-3517, and another as-yet unnumbered LWG issue which corrects the discrepancy introduced by LWG-3313 between the constraints on join_view::iterator::operator--()/::operator--(int) and the definition of iterator_concept/iterator_category.

@StephanTLavavej StephanTLavavej added cxx20 C++20 feature ranges C++20/23 ranges labels Nov 9, 2020
@CaseyCarter CaseyCarter self-assigned this Nov 11, 2020
StephanTLavavej
StephanTLavavej requested changes Nov 13, 2020
View reviewed changes
@StephanTLavavej StephanTLavavej mentioned this pull request Nov 13, 2020
Closed
52 tasks
miscco
miscco commented Nov 13, 2020
View reviewed changes
miscco
miscco commented Nov 13, 2020
View reviewed changes
@miscco miscco force-pushed the join_view branch 2 times, most recently from cd7bf91 to 602c2ca Compare November 14, 2020 11:14
@miscco
Copy link
Contributor Author

miscco commented Nov 15, 2020

FYI: Filed LWG-3500 for join_view::iterator::operator->()

AdamBucior
AdamBucior reviewed Nov 15, 2020
View reviewed changes
StephanTLavavej
StephanTLavavej reviewed Nov 20, 2020
View reviewed changes
@StephanTLavavej StephanTLavavej mentioned this pull request Dec 16, 2020
Closed
Base automatically changed from master to main January 28, 2021 00:35
miscco
miscco commented Feb 16, 2021
View reviewed changes
Copy link
Contributor Author

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it

@CaseyCarter
a few fixes:
39ecceb 
* wrap overlong lines
* avoid lambda in `_Iterator::_Satisfy` from throughput paranoia
* the MSVC bug was pre-existing
miscco
miscco commented Mar 16, 2021
View reviewed changes
miscco
miscco commented Mar 16, 2021
View reviewed changes
miscco
miscco commented Mar 16, 2021
View reviewed changes
miscco
miscco commented Mar 16, 2021
View reviewed changes
miscco
miscco commented Mar 16, 2021
View reviewed changes
miscco
miscco commented Mar 16, 2021
View reviewed changes
CaseyCarter
CaseyCarter reviewed Mar 16, 2021
View reviewed changes
@CaseyCarter CaseyCarter removed their assignment Mar 16, 2021
CaseyCarter added a commit to CaseyCarter/STL that referenced this pull request Mar 17, 2021
@CaseyCarter
Define __cpp_lib_ranges
158c5ca 
Update list of implemented proposals

I have verified that all proposals and LWG issues listed in microsoft#39 are implemented either on main, in microsoft#1436, or in microsoft#1731.
CaseyCarter added a commit to CaseyCarter/STL that referenced this pull request Mar 17, 2021
@CaseyCarter
Define __cpp_lib_ranges
e9b2812 
Update list of implemented proposals

I have verified that all 23 proposals and 35 LWG issues listed in microsoft#39 are implemented either on main, in microsoft#1436, or in microsoft#1731.
@CaseyCarter CaseyCarter mentioned this pull request Mar 17, 2021
Merged
StephanTLavavej
StephanTLavavej approved these changes Mar 17, 2021
View reviewed changes
CaseyCarter and others added 2 commits March 16, 2021 19:18
@CaseyCarter @StephanTLavavej
Apply suggestions from code review
3bc8db8 
STL's mechanical fixes. (I certainly won't miss working in `// clang-format off` zones when clang-format learns concepts and requires-clauses.)

Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
@CaseyCarter
Update tests/std/include/range_algorithm_support.hpp
78d1ac9 
STL's non-mechanical suggestion.
@CaseyCarter CaseyCarter removed their assignment Mar 17, 2021
@CaseyCarter CaseyCarter self-assigned this Mar 17, 2021
@CaseyCarter CaseyCarter merged commit 378dcad into microsoft:main Mar 18, 2021
@CaseyCarter
Copy link
Contributor

CaseyCarter commented Mar 18, 2021 •
edited
Loading

I will join you in celebrating finally merging this PR! 🎉

@CaseyCarter CaseyCarter removed their assignment Mar 18, 2021
CaseyCarter added a commit that referenced this pull request Mar 18, 2021
@CaseyCarter
Define __cpp_lib_ranges (#1748)
1cca482 
Update list of implemented proposals

I have verified that all 23 proposals and 35 LWG issues listed in #39 are implemented either on main, in #1436, or in #1731.

Fixes #39
@miscco miscco deleted the join_view branch March 19, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+3 more reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@cpplearner cpplearner cpplearner left review comments

@AdamBucior AdamBucior AdamBucior left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cxx20 C++20 feature ranges C++20/23 ranges

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miscco @CaseyCarter @StephanTLavavej @cpplearner @AdamBucior