Implement ranges::split_view #1731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
CaseyCarter
commented
Mar 11, 2021
Contributor
Author
CaseyCarter
left a comment
CaseyCarter
left a comment
There was a problem hiding this comment.
Github, why can't I "Request Changes" on my own PR?
StephanTLavavej
requested changes
Mar 12, 2021
StephanTLavavej
approved these changes
Mar 12, 2021
cpplearner
reviewed
Mar 12, 2021
cpplearner
reviewed
Mar 12, 2021
StephanTLavavej
approved these changes
Mar 12, 2021
miscco
reviewed
Mar 12, 2021
miscco
reviewed
Mar 12, 2021
miscco
reviewed
Mar 12, 2021
Contributor
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
Its been a time since I really looked at a view, so I hope this are not too dumb questions
StephanTLavavej
approved these changes
Mar 13, 2021
StephanTLavavej
approved these changes
Mar 16, 2021
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Mar 17, 2021
Update list of implemented proposals I have verified that all proposals and LWG issues listed in microsoft#39 are implemented either on main, in microsoft#1436, or in microsoft#1731.
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Mar 17, 2021
Update list of implemented proposals I have verified that all 23 proposals and 35 LWG issues listed in microsoft#39 are implemented either on main, in microsoft#1436, or in microsoft#1731.
Contributor
Author
|
Thanks for your contribution! (The pun is pretty subtle here: I'm thanking myself, as if I had a split personality.) |
CaseyCarter
added a commit
that referenced
this pull request
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in_in_result,ranges::_Find_unchecked,ranges::mismatch, and_Require_constantup from<algorithm>into<xulility>sosplit_viewcan use them without including all of<algorithm>in<ranges>. Moves_Convertible_fromup from<xmemory>to<xutility>for the same reason.Partially addresses #39.