Partially activate more Header Units test coverage #1628
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Microsoft-internal compiler bug VSO-1271718 "Standard Library Header Units ICE with C++20 chrono" has been fixed for VS 2019 16.10 Preview 1. To prevent compiler regressions between now and the time when Preview 1 ships publicly, we should activate the affected parts of the Standard Library Header Units test for the MSVC-internal test harness.
When Preview 1 is publicly available, we'll be able to remove these workarounds unconditionally.
As an aside, what triggered this ICE was the technique needed to implement LWG-3260:
STL/stl/inc/chrono
Lines 1253 to 1254 in 47cd703