Skip to content

Partially activate more Header Units test coverage #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StephanTLavavej merged 1 commit into from
Feb 12, 2021
+3 −3
Merged

Partially activate more Header Units test coverage #1628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/std/tests/P1502R1_standard_library_header_units/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,11 +324,11 @@ int main() {
puts("Testing <future>.");
promise<int> p{};
future<int> f{p.get_future()};
#if 0 // TRANSITION, VSO-1271718 (Standard Library Header Units ICE with C++20 chrono)
#ifdef MSVC_INTERNAL_TESTING // TRANSITION, VSO-1271718 (Standard Library Header Units ICE with C++20 chrono)
assert(f.wait_for(chrono::seconds{0}) == future_status::timeout);
#endif // ^^^ no workaround ^^^
p.set_value(1729);
#if 0 // TRANSITION, VSO-1271718 (Standard Library Header Units ICE with C++20 chrono)
#ifdef MSVC_INTERNAL_TESTING // TRANSITION, VSO-1271718 (Standard Library Header Units ICE with C++20 chrono)
assert(f.wait_for(chrono::seconds{0}) == future_status::ready);
#endif // ^^^ no workaround ^^^
assert(f.get() == 1729);
Expand Down Expand Up @@ -760,7 +760,7 @@ int main() {
}
l.count_down(); // tell main() that we're done
while (!token.stop_requested()) {
#if 0 // TRANSITION, VSO-1271718 (Standard Library Header Units ICE with C++20 chrono)
#ifdef MSVC_INTERNAL_TESTING // TRANSITION, VSO-1271718 (Standard Library Header Units ICE with C++20 chrono)
this_thread::sleep_for(10ms); // not a timing assumption; avoids spinning furiously
#endif // ^^^ no workaround ^^^
}
Expand Down