Skip to content

Conversation

@StephanTLavavej
Copy link
Member

  • Update the Node.js version in the README.
  • npm update.
  • Manually update weekly_table.js.
  • Upgrade to chart.js 3.0.0-rc.2 and chartjs-adapter-date-fns 1.1.0-beta.1.
  • Prepare to be run by GitHub Actions.
    • Thanks to @isra-fel for identifying these issues.
    • GitHub Actions will directly provide the Personal Access Token as an environment variable, so in that case we should skip attempting to load the .env file. (The logic for loading the .env file is unchanged, with separate failure scenarios for "file doesn't exist" and "file exists but doesn't contain the PAT".)
    • The progress bars write to stderr by default. When stderr is redirected to a file (which GitHub Actions does), they don't behave nicely and the MultiBar simply fails. We can detect such redirection and set noTTYOutput, which causes cli-progress to emit nice output. (This inspects process.stderr.isTTY, instead of GitHub Actions having to set something special to indicate that it's running.)
  • Set the time zone for gather_stats.js to America/Los_Angeles.
    • Luxon defaults to using the local time zone, so the script was behaving differently in different time zones - such as the one used by GitHub Actions runners.
  • Regen the daily and monthly tables by manually running gather_stats.js.
    • There's some churn here, apparently caused by an issue and a PR vanishing. The PR appears to be "Simplify _FDscale in xfdscale.cpp (psx is 0, so don't even bother checking #609)"; the user's account appears to have been deleted. Approximately 40 days are impacted because of the "merged PRs" smoothing window.
  • Automatically regen the tables.
    • This commit was created by the GitHub Actions bot, and indicates that the generation process is stable (emits the same data, plus an additional day).

Note that by itself, this PR won't enable GitHub Actions; there will be a followup PR to main, and I'll need to enable GitHub Actions for the repo, and I'll probably need to modify the gh-pages branch protection policy.

📉 Live preview: stephantlavavej.github.io/STL/

StephanTLavavej and others added 8 commits March 21, 2021 18:35
Co-authored-by: Yeming Liu <Yeming.Liu@microsoft.com>
There's some churn here, apparently caused by an issue and a PR vanishing.
The PR appears to be "Simplify _FDscale in xfdscale.cpp (microsoft#609)";
the user's account appears to have been deleted.
@StephanTLavavej StephanTLavavej added the documentation Related to documentation or comments label Mar 22, 2021
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner March 22, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Related to documentation or comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants