Status Chart: Weekly update, fix Luxon 2.0 breaking change #2076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
added
documentation
mnatsuhara
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I updated Luxon's major version to 2.0 in #2063, the next automated update changed tons of data points. As they documented, we need to use
Settings.defaultZoneto make the script's calculations always use Pacific Time (originally done in #1764).I've verified this change by temporarily enabling automated updates in my fork, and verifying that GitHub Actions will generate exactly the old data (followed by newly added days).
📈 Live preview: stephantlavavej.github.io/STL/