-
Notifications
You must be signed in to change notification settings - Fork 1.6k
More optimizations for contiguous iterators #1772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
CaseyCarter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nitpicky things.
CaseyCarter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Repeating one comment that was buried in my first review and went unnoticed.
|
@AdamBucior I think the recommendation was to simply use a 👍 emoji and resolving the comment rather than a reply, when review comments are adopted without change. That helps a lot keeping the inbox clean |
|
BTW this is ready for review |
|
Thanks for continuing these performance improvements! I'm going to initially Changelog this under "Dev17" 17.0 Preview 1, but we're going to try to port it (along with C++20 feature work) to VS 2019 16.10 Preview 3. 🚀 🚀 🚀 |
Changes in this PR:
memmoveoptimization inranges::copy/movefamilymemcpyoptimization inranges::uninitialized_copy/moveto non-common rangesranges::destroy_Ptr_*_cat_Ptr_copy_cat<move_iterator<*>, *>should derive from_Ptr_move_cat