Implement P1425 iterator range constructors for stack and queue #1994
Conversation
Addresses microsoft#1965
Addresses microsoft#1965
This comment has been minimized.
This comment has been minimized.
miscco
force-pushed
the
p1425r4-stack-queue-constructors
branch
from
b3116f8 to
ccdf327
Compare
|
Is it intended not to apply LWG-3506 to C++14/17 modes? |
|
That is a good point. The maintainers can give direction |
stl/inc/queue
Outdated
| template <class _InIt, class _Alloc, enable_if_t<uses_allocator_v<_Container, _Alloc>, int> = 0> | ||
| priority_queue(_InIt _First, _InIt _Last, const _Pr& _Pred, const _Container& _Cont, const _Alloc& _Al) |
There was a problem hiding this comment.
According to LWG-3522, all of these priority_queue constructors taking _InIt should be additionally constrained by _Is_iterator, so I think we need to conjunction_v all 4 of them.
There was a problem hiding this comment.
I went with simple && as I believe we do not really need the short circuiting of conjunction and might avoid some type instantiations
miscco
force-pushed
the
p1425r4-stack-queue-constructors
branch
from
139a594 to
a9e8c3d
Compare
This comment has been minimized.
This comment has been minimized.
…eduction Guides" This reverts commit 55cea37.
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good, thanks! I'll validate and push some changes.
|
I'm mirroring this to an MSVC-internal PR. It's totally fine to push changes for code review feedback, but please notify me in that case. |
| using namespace std; | ||
|
|
||
| constexpr int some_data[] = {0, 1, 2, 3, 4, 5}; | ||
| constexpr int additional_data[] = {6, 7, 8, 9, 10, 11}; |
There was a problem hiding this comment.
These variable names are truly inspired. (No change requested.)
|
Thanks for implementing this C++23 feature and related LWG issue resolutions! 😻 ✔️ 🚀 |
4 participants
This implements P1425.
While we are at it it also implements LWG-3506 and LWG-3522. (There is nothing to do for LWG-3529 - it's already implemented.)
Addresses #1965
Fixes #1973