Implement LWG-3480, directory_iterator and recursive_directory_iterator are ranges
#2340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
approved these changes
Nov 16, 2021
| inline constexpr bool enable_view<filesystem::recursive_directory_iterator> = true; | ||
| } // namespace ranges | ||
| #endif // __cpp_lib_concepts | ||
|
|
Contributor
There was a problem hiding this comment.
Hint to other reviewers: our end overloads for directory_iterator and recursive_directory_iterator already take their argument by value as in the proposed resolution of LWG-3480. In fact they always have, all the way back to MSVC-PR-108103! I'll have to thank Gor for realizing that WG21 would want to change these 3.5 years later =)
[No change requested.]
StephanTLavavej
approved these changes
Nov 16, 2021
| inline constexpr bool enable_view<filesystem::recursive_directory_iterator> = true; | ||
| } // namespace ranges | ||
| #endif // __cpp_lib_concepts | ||
|
|
39 tasks
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for range-ifying these iterators and getting the codebase closer to zero LWG issues! 😸 🚀 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2315