Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix writing NaN to the output stream with a set locale #3868

Merged
merged 5 commits into from
Jul 14, 2023
Merged

fix writing NaN to the output stream with a set locale #3868

merged 5 commits into from
Jul 14, 2023

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Jul 12, 2023

Fixes #3867

@fsb4000 fsb4000 requested a review from a team as a code owner July 12, 2023 12:42
frederick-vs-ja
frederick-vs-ja reviewed Jul 12, 2023
View reviewed changes
stl/inc/xlocnum Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej added the bug Something isn't working label Jul 12, 2023
@StephanTLavavej StephanTLavavej self-assigned this Jul 12, 2023
StephanTLavavej
StephanTLavavej reviewed Jul 13, 2023
View reviewed changes
stl/inc/xlocnum Outdated Show resolved Hide resolved
stl/inc/xlocnum Outdated Show resolved Hide resolved
tests/std/tests/GH_003867_output_nan/test.cpp Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment Jul 13, 2023
@StephanTLavavej
Copy link
Member

Thanks! I've verified that the export surface is now unaffected.

@StephanTLavavej StephanTLavavej self-assigned this Jul 13, 2023
@StephanTLavavej
Copy link
Member

I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Copy link
Member

I've had to push an additional commit to defend against macroized isnan. (We consistently do so, and have a test in the MSVC-internal test harness to verify this.)

FYI @CaseyCarter as you approved right before I pushed.

@StephanTLavavej StephanTLavavej merged commit 28ea30a into microsoft:main Jul 14, 2023
35 checks passed
@StephanTLavavej
Copy link
Member

Tha,nks for fix,ing thi,s hil,ari,ous bug! 🐞 🛠️ 😹

@fsb4000 fsb4000 deleted the fix_nan branch July 14, 2023 04:27
@StephanTLavavej StephanTLavavej mentioned this pull request Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederick-vs-ja frederick-vs-ja frederick-vs-ja left review comments

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<iostream>: Writing NaN to the output stream with a set locale results in a weird output
4 participants
@fsb4000 @StephanTLavavej @CaseyCarter @frederick-vs-ja