Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iostreams with imbued locales to print INFs correctly #3877

Merged
merged 6 commits into from
Jul 20, 2023

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Jul 14, 2023

Followup to #3868.

@fsb4000 fsb4000 requested a review from a team as a code owner July 14, 2023 14:58
@fsb4000

This comment was marked as resolved.

@strega-nil-ms

This comment was marked as resolved.

stl/inc/xlocnum Outdated Show resolved Hide resolved
@StephanTLavavej

This comment was marked as resolved.

@StephanTLavavej StephanTLavavej self-assigned this Jul 14, 2023
@StephanTLavavej StephanTLavavej added the bug Something isn't working label Jul 14, 2023
@StephanTLavavej StephanTLavavej removed their assignment Jul 14, 2023
@StephanTLavavej
Copy link
Member

I've pushed changes to:

  • Use isfinite as suggested by @frederick-vs-ja, which is faster and simpler than testing isnan and isinf separately,
  • Rename _Fput_v2 to _Fput_v3 because the sense of the bool is flipping (this isn't really necessary if _Fput_v2 never shipped for production usage, but it was the cleanest thing to do),
  • Guard the test with TEST_CUSTOM_FACET, with a comment explaining why,
  • Update Dev11_0496153_locale_ctor which had an equivalent guard that was phrased in a much more confusing manner. (Its comment previously explained the preprocessor logic in English, but not why it existed.)

@StephanTLavavej
Copy link
Member

D'oh, I checked std but didn't rerun the libcxx failures.

@StephanTLavavej StephanTLavavej self-assigned this Jul 20, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit c39d63b into microsoft:main Jul 20, 2023
35 checks passed
@StephanTLavavej
Copy link
Member

♾️ 🌐 🎉

@fsb4000 fsb4000 deleted the fix_inf branch July 21, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants