Implement ranges::fill and ranges::fill_n #904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Closed
StephanTLavavej
requested changes
Jun 17, 2020
CaseyCarter
suggested changes
Jun 18, 2020
CaseyCarter
approved these changes
Jun 19, 2020
Contributor
CaseyCarter
left a comment
CaseyCarter
left a comment
There was a problem hiding this comment.
Looks good, modulo clang-format complaining about stl/inc/algorithm.
Member
|
Updated the PR title to match the other ranges PRs (also #905). |
mnatsuhara
reviewed
Jun 22, 2020
StephanTLavavej
requested changes
Jun 22, 2020
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good! Minor stylistic comments and a bit of test coverage requested.
CaseyCarter
suggested changes
Jun 26, 2020
CaseyCarter
approved these changes
Jun 29, 2020
StephanTLavavej
requested changes
Jun 29, 2020
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
I think this will be ready to merge after one more round of very small fixes!
StephanTLavavej
approved these changes
Jun 30, 2020
CaseyCarter
approved these changes
Jul 1, 2020
Contributor
|
Thanks for your contribution which fills a void in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.