Implement ranges heap algorithms #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2020
Closed
`ranges::is_heap`, `ranges::is_heap_until`, `ranges::make_heap`, `ranges::push_heap`, `ranges::pop_heap`, and `ranges::sort_heap`.
miscco
reviewed
Jun 28, 2020
Contributor
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
Some smaller nits, I havent really looked at the algortihm itself
* Extend `_Rewrap_subrange` to accept a range for its first parameter in addiiton to the existing iterator support. * Add `_Rewrap_iterator`, similar to `_Rewrap_subrange`.
miscco
reviewed
Jun 29, 2020
StephanTLavavej
changed the title
StephanTLavavej
requested changes
Jun 30, 2020
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good to me - a few superficial comments and one "let's clean up more warning suppressions".
StephanTLavavej
approved these changes
Jun 30, 2020
StephanTLavavej
approved these changes
Jun 30, 2020
mnatsuhara
approved these changes
Jul 1, 2020
StephanTLavavej
approved these changes
Jul 1, 2020
Contributor
Author
|
Thanks for contributing a whole heap of |
fengjixuchui
added a commit
to fengjixuchui/STL
that referenced
this pull request
Jul 2, 2020
Implement ranges heap algorithms (microsoft#930)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ranges::is_heap,ranges::is_heap_until,ranges::make_heap,ranges::push_heap,ranges::pop_heap, andranges::sort_heap.Partially addresses #39.