Add type to FileReader event target. #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mhegazy
reviewed
Mar 29, 2018
baselines/dom.generated.d.ts
Outdated
| onloadend: ((this: FileReader, ev: ProgressEvent) => any) | null; | ||
| onloadstart: ((this: FileReader, ev: ProgressEvent) => any) | null; | ||
| onprogress: ((this: FileReader, ev: ProgressEvent) => any) | null; | ||
| onabort: ((this: FileReader, ev: ProgressEvent & {target: FileReader}) => any) | null; |
There was a problem hiding this comment.
i would create a new type FilreReaderProgressEvent that extends ProgressEvent and use that instead.
There was a problem hiding this comment.
Thank you for reviewing. I have added FileReaderProgressEvent.
mhegazy
reviewed
Mar 30, 2018
baselines/dom.generated.d.ts
Outdated
| readonly target: FileReader | null; | ||
| } | ||
|
|
||
| declare var FileReaderProgressEvent: { |
There was a problem hiding this comment.
this should not be added. set "no-interface-object": 1, on the new interface to avoid the creation of a var.
mhegazy
reviewed
Mar 30, 2018
inputfiles/addedTypes.json
Outdated
| "override-type": "FileReader | null" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
add "no-interface-object": 1,
|
Removed unnecessary |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes microsoft/TypeScript#4163.
The FileReader API spec says the event target is
FileReaderso I giveFileReadertype totargetofev.