Skip to content

Add type to FileReader event target. #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 30, 2018
Merged

Add type to FileReader event target. #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90971b1
Add type to FileReader event target.
rch850 Mar 29, 2018
a8d83a6
Add FilreReaderProgressEvent
rch850 Mar 29, 2018
15b367d
Delete FileReaderProgressEvent object
rch850 Mar 30, 2018
ba5a702
Fix missing FileReaderProgressEvent in webworker
rch850 Mar 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4722,12 +4722,12 @@ interface FileReaderEventMap {

interface FileReader extends EventTarget {
readonly error: DOMException | null;
onabort: ((this: FileReader, ev: ProgressEvent) => any) | null;
onerror: ((this: FileReader, ev: ProgressEvent) => any) | null;
onload: ((this: FileReader, ev: ProgressEvent) => any) | null;
onloadend: ((this: FileReader, ev: ProgressEvent) => any) | null;
onloadstart: ((this: FileReader, ev: ProgressEvent) => any) | null;
onprogress: ((this: FileReader, ev: ProgressEvent) => any) | null;
onabort: ((this: FileReader, ev: FileReaderProgressEvent) => any) | null;
onerror: ((this: FileReader, ev: FileReaderProgressEvent) => any) | null;
onload: ((this: FileReader, ev: FileReaderProgressEvent) => any) | null;
onloadend: ((this: FileReader, ev: FileReaderProgressEvent) => any) | null;
onloadstart: ((this: FileReader, ev: FileReaderProgressEvent) => any) | null;
onprogress: ((this: FileReader, ev: FileReaderProgressEvent) => any) | null;
readonly readyState: number;
readonly result: any;
abort(): void;
Expand All @@ -4752,6 +4752,10 @@ declare var FileReader: {
readonly LOADING: number;
};

interface FileReaderProgressEvent extends ProgressEvent {
readonly target: FileReader | null;
}

interface FocusEvent extends UIEvent {
readonly relatedTarget: EventTarget;
initFocusEvent(typeArg: string, canBubbleArg: boolean, cancelableArg: boolean, viewArg: Window, detailArg: number, relatedTargetArg: EventTarget): void;
Expand Down Expand Up @@ -9681,6 +9685,12 @@ declare var PannerNode: {
new(): PannerNode;
};

interface ParentNode {
readonly childElementCount: number;
readonly firstElementChild: Element | null;
readonly lastElementChild: Element | null;
}

interface ParentNode {
readonly children: HTMLCollection;
querySelector<K extends keyof HTMLElementTagNameMap>(selectors: K): HTMLElementTagNameMap[K] | null;
Expand All @@ -9691,12 +9701,6 @@ interface ParentNode {
querySelectorAll<E extends Element = Element>(selectors: string): NodeListOf<E>;
}

interface ParentNode {
readonly childElementCount: number;
readonly firstElementChild: Element | null;
readonly lastElementChild: Element | null;
}

interface Path2D extends CanvasPathMethods {
}

Expand Down
16 changes: 10 additions & 6 deletions baselines/webworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,12 +588,12 @@ interface FileReaderEventMap {

interface FileReader extends EventTarget {
readonly error: DOMException | null;
onabort: ((this: FileReader, ev: ProgressEvent) => any) | null;
onerror: ((this: FileReader, ev: ProgressEvent) => any) | null;
onload: ((this: FileReader, ev: ProgressEvent) => any) | null;
onloadend: ((this: FileReader, ev: ProgressEvent) => any) | null;
onloadstart: ((this: FileReader, ev: ProgressEvent) => any) | null;
onprogress: ((this: FileReader, ev: ProgressEvent) => any) | null;
onabort: ((this: FileReader, ev: FileReaderProgressEvent) => any) | null;
onerror: ((this: FileReader, ev: FileReaderProgressEvent) => any) | null;
onload: ((this: FileReader, ev: FileReaderProgressEvent) => any) | null;
onloadend: ((this: FileReader, ev: FileReaderProgressEvent) => any) | null;
onloadstart: ((this: FileReader, ev: FileReaderProgressEvent) => any) | null;
onprogress: ((this: FileReader, ev: FileReaderProgressEvent) => any) | null;
readonly readyState: number;
readonly result: any;
abort(): void;
Expand All @@ -618,6 +618,10 @@ declare var FileReader: {
readonly LOADING: number;
};

interface FileReaderProgressEvent extends ProgressEvent {
readonly target: FileReader | null;
}

interface FileReaderSync {
readAsArrayBuffer(blob: Blob): any;
readAsBinaryString(blob: Blob): void;
Expand Down
14 changes: 14 additions & 0 deletions inputfiles/addedTypes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,20 @@
}
}
},
"FileReaderProgressEvent": {
"name": "FileReaderProgressEvent",
"extends": "ProgressEvent",
"properties": {
"property": {
"name": {
"name": "target",
"read-only": 1,
"override-type": "FileReader | null"
}
}
},
"no-interface-object": "1"
},
"BroadcastChannel": {
"name": "BroadcastChannel",
"extends": "EventTarget",
Expand Down
1 change: 1 addition & 0 deletions inputfiles/knownWorkerTypes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"File",
"FileList",
"FileReader",
"FileReaderProgressEvent",
"FormData",
"Headers",
"IDBCursor",
Expand Down
24 changes: 24 additions & 0 deletions inputfiles/overridingTypes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1761,6 +1761,30 @@
"name": "FileReader",
"properties": {
"property": {
"onloadstart": {
"name": "onloadstart",
"override-type": "(this: FileReader, ev: FileReaderProgressEvent) => any"
},
"onprogress": {
"name": "onprogress",
"override-type": "(this: FileReader, ev: FileReaderProgressEvent) => any"
},
"onload": {
"name": "onload",
"override-type": "(this: FileReader, ev: FileReaderProgressEvent) => any"
},
"onabort": {
"name": "onabort",
"override-type": "(this: FileReader, ev: FileReaderProgressEvent) => any"
},
"onerror": {
"name": "onerror",
"override-type": "(this: FileReader, ev: FileReaderProgressEvent) => any"
},
"onloadend": {
"name": "onloadend",
"override-type": "(this: FileReader, ev: FileReaderProgressEvent) => any"
},
"result": {
"name": "result",
"override-type": "any"
Expand Down