Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing space on assignment breaking highlighting #654

Closed
mjbvz opened this issue Aug 20, 2018 · 1 comment
Closed

Trailing space on assignment breaking highlighting #654

mjbvz opened this issue Aug 20, 2018 · 1 comment

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Aug 20, 2018

TS and JS Grammar Extension version: 0.0.43 / latest

Code

let app = 1 
// If no app selected in UI or no app set in config, or they match return true
if (!app || !this.configModelId || app.appId === this.configModelId) {
    return true
}

Note trailing space after 1. Highlighting is broken after this line

screen shot 2018-08-20 at 6 48 38 pm

mattmazzola added a commit to microsoft/ConversationLearner-SDK that referenced this issue Aug 20, 2018
There is current bug with syntax highlighting on TypeScripot files which have trailing white space.

microsoft/TypeScript-TmLanguage#654
microsoft/vscode#56706 (comment)
mattmazzola added a commit to microsoft/ConversationLearner-SDK that referenced this issue Aug 20, 2018
There is current bug with syntax highlighting on TypeScripot files which have trailing white space.

microsoft/TypeScript-TmLanguage#654
microsoft/vscode#56706 (comment)
@mjbvz
Copy link
Contributor Author

mjbvz commented Aug 21, 2018

Similar case:

let app = 1 
{
	1 + 1
}

mattmazzola added a commit to microsoft/conversationlearner that referenced this issue Dec 16, 2019
There is current bug with syntax highlighting on TypeScripot files which have trailing white space.

microsoft/TypeScript-TmLanguage#654
microsoft/vscode#56706 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant