TypeScript Syntax Highlighting Broken

[mattmazzola]

Issue Type: Bug

I updated to latest version 1.26.1 and now code that was viewed properly before no longer has proper syntax highlighting

VS Code version: Code 1.26.1 (493869e, 2018-08-16T18:37:28.532Z)
OS version: Windows_NT ia32 10.0.17134

System Info

Item	Value
CPUs	Intel(R) Xeon(R) CPU E5-1650 v3 @ 3.50GHz (12 x 3492)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Memory (System)	31.91GB (16.45GB free)
Process Argv	C:\Program Files (x86)\Microsoft VS Code\Code.exe
Screen Reader	no
VM	0%

Extensions (10)

Extension	Author (truncated)	Version
bracket-pair-colorizer	Coe	1.0.59
gc-excelviewer	Gra	2.1.25
code-beautifier	mic	2.1.0
dotenv	mik	1.0.1
python	ms-	2018.7.1
csharp	ms-	1.15.2
PowerShell	ms-	1.8.3
debugger-for-chrome	msj	4.8.2
code-spell-checker	str	1.6.10
vscode-adaptivecards	tom	1.1.3

[gluons]

Subscribed!

I also face the same problem. Colors look weird and inconsistent.

[mjbvz]

Please share the text of the code along with screenshots

[mattmazzola]

Here is a link to the file I had screenshot from above:
https://github.com/Microsoft/ConversationLearner-SDK/blob/c0c4f4a511b754c595e6368fcbd7e6b585665898/src/CLRunner.ts

Interestingly I noticed the syntax highlighting on this file is also broken in almost the same locations with same affects on GitHub as it is in VSCode. Perhaps this can be clue to fix the issue if they use the same dependency for computing this.

Notice it starts to break at (colors start to be mismatched):
https://github.com/Microsoft/ConversationLearner-SDK/blob/c0c4f4a511b754c595e6368fcbd7e6b585665898/src/CLRunner.ts#L166

(Notice the return statement just below is not red anymore)

And is completely broken here (all the same color):
https://github.com/Microsoft/ConversationLearner-SDK/blob/c0c4f4a511b754c595e6368fcbd7e6b585665898/src/CLRunner.ts#L259

[mjbvz]

Seems fixed in latest insiders build

Let me know if you still see this issue in the current insiders

[gluons]

My file: https://github.com/gluons/vue-pack/blob/997ad7b69ab14b64145dfa04651ec56ab3a4cd75/packages/%40gluons/types/src/Configuration.ts

[mjbvz]

@gluons Opened microsoft/TypeScript-TmLanguage#653 for that

In the future please open a separate issue as it makes tracking and management easier

[mattmazzola]

Hmm. I just downloaded the insiders and still see the error. Even disabled all extensions. Was the version below the one you were using? Is there a better way for me to verify?

VS Code version: Code - Insiders 1.27.0-insider (6e55926, 2018-08-20T08:36:52.887Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item	Value
CPUs	Intel(R) Xeon(R) CPU E5-1650 v3 @ 3.50GHz (12 x 3492)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Memory (System)	31.91GB (15.03GB free)
Process Argv	C:\Users\mattm\AppData\Local\Programs\Microsoft VS Code Insiders\Code - Insiders.exe
Screen Reader	no
VM	0%

Extensions: none

[mjbvz]

Oh yeah format on paste fixes this if you copy it from github. Caused by a trailing space messing up syntax highlighting. Opened microsoft/TypeScript-TmLanguage#654 to track this