Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding azure pipelines #682

Merged
merged 7 commits into from
Nov 29, 2018
Merged

Adding azure pipelines #682

merged 7 commits into from
Nov 29, 2018

Conversation

damccorm
Copy link

@damccorm damccorm commented Nov 8, 2018

This pipeline points at my fork, you can see its successfully building.

Main Advantages:

  1. Azure Pipelines lets us build and test on Windows, Linux, and macOS (one CI service instead of multiple)
  2. Azure Pipelines provides unlimited minutes and 10 parallel jobs for open source projects (which means faster builds)
  3. Great integration with GitHub

Next steps once this PR is submitted

  1. Point pipeline at source repo instead of my fork
  2. Transfer ownership of pipeline to azuredatastudio maintainers
  3. I’ll create another PR to add a status badge
  4. Once we see its working, remove travis/appveyor since they'll be redundant

@sheetalkamat
Copy link
Member

Added @weswigham since he handles pipelines. Thanks.

steps:
- task: NodeTool@0
inputs:
versionSpec: '8.9'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be templated so we get a node 8 and a latest stable node build, like the Travis yaml specifies? We don't need to test every version on every platform; but checking both versions in addition to each platform would be nice (I'd check each platform on latest stable and 'nix only for node 8).

On a related note: are there any fast build options we can opt in to? Like Travis had a container opt in (sudo: false); from what I understand the new non-preview 'nix images aren't containerized builds anymore. Mostly just curious here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weswigham I updated so that it gives the latest version of 11, unfortunately I don't think the node tool installer can check for the latest major version though (it will automatically bump with minor versions now though). Also, it looks like Windows builds are failing on Node 11, npm install seems to fail, it works fine on node 8 though.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What python version does the windows 10 vm have installed? Becuase that error looks like a node-gyp python version error.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the vm be provisioned with python 2 instead of python 3?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good call. Updated accordingly and it is no longer failing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weswigham when you get a chance would you mind taking a look at this again? I think it should be good to go.

@weswigham
Copy link
Member

@sheetalkamat this looks fine to me - if you're OK with it, we can use it.

@sheetalkamat sheetalkamat merged commit f0edf83 into microsoft:master Nov 29, 2018
@damccorm
Copy link
Author

@sheetalkamat @weswigham thanks for getting this in! I just created the new Pipeline pointing at this repo (instead of my fork) here and added you both to the owning team. In a moment I'll also create a PR to add a build status badge to the README. At this point there should just be 3 remaining steps:

  1. Add Pipelines as a PR check
  2. (optionally) accept my build status badge PR
  3. (optionally) Remove Travis after you see Pipelines working for a bit

@sheetalkamat
Copy link
Member

@damccorm The build is failing on azure with some error. Can you please take a look at whats going on. Thanks

@damccorm
Copy link
Author

Sorry I missed this. Taking a look now, it seems like the builds are running again? We had an LSI that I think could have been related to this, so maybe that was the cause?

@weswigham
Copy link
Member

We swapped out the service connection the build was using, since the build was failing because the one it was using seemed to suddenly lack any permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants