-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding azure pipelines #682
Conversation
Added @weswigham since he handles pipelines. Thanks. |
azure-pipelines-template.yml
Outdated
steps: | ||
- task: NodeTool@0 | ||
inputs: | ||
versionSpec: '8.9' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be templated so we get a node 8
and a latest stable node build, like the Travis yaml specifies? We don't need to test every version on every platform; but checking both versions in addition to each platform would be nice (I'd check each platform on latest stable and 'nix only for node 8
).
On a related note: are there any fast build options we can opt in to? Like Travis had a container opt in (sudo: false); from what I understand the new non-preview 'nix images aren't containerized builds anymore. Mostly just curious here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weswigham I updated so that it gives the latest version of 11, unfortunately I don't think the node tool installer can check for the latest major version though (it will automatically bump with minor versions now though). Also, it looks like Windows builds are failing on Node 11, npm install seems to fail, it works fine on node 8 though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What python version does the windows 10 vm have installed? Becuase that error looks like a node-gyp
python version error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the vm be provisioned with python 2 instead of python 3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good call. Updated accordingly and it is no longer failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weswigham when you get a chance would you mind taking a look at this again? I think it should be good to go.
@sheetalkamat this looks fine to me - if you're OK with it, we can use it. |
@sheetalkamat @weswigham thanks for getting this in! I just created the new Pipeline pointing at this repo (instead of my fork) here and added you both to the owning team. In a moment I'll also create a PR to add a build status badge to the README. At this point there should just be 3 remaining steps:
|
@damccorm The build is failing on azure with some error. Can you please take a look at whats going on. Thanks |
Sorry I missed this. Taking a look now, it seems like the builds are running again? We had an LSI that I think could have been related to this, so maybe that was the cause? |
We swapped out the service connection the build was using, since the build was failing because the one it was using seemed to suddenly lack any permissions. |
This pipeline points at my fork, you can see its successfully building.
Main Advantages:
Next steps once this PR is submitted