-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding azure pipelines #682
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
373dbd0
Adding azure pipelines
b3167a9
Set up multi-reporter
30e5738
Add xunit.xml to .gitignore so it doesn't get checked in
939659e
Change node version used
1baa4c3
Rename duplicate job name
553cfec
Switch legacy build to linux
bd6461b
Use python 2
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
# Make sure baseline files have consistent line endings | ||
*.txt text eol=lf |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
steps: | ||
- task: NodeTool@0 | ||
inputs: | ||
versionSpec: '8.9' | ||
displayName: 'Install Node.js' | ||
|
||
- script: npm install | ||
displayName: 'npm install' | ||
|
||
- script: npm install -g mocha | ||
displayName: 'Install mocha' | ||
|
||
- script: npm install -g mocha-junit-reporter | ||
displayName: 'Install mocha junit reporter' | ||
damccorm marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
- script: npm run build | ||
displayName: 'Build' | ||
|
||
- script: mocha tests/test.js --reporter mocha-junit-reporter | ||
displayName: 'Test' | ||
|
||
- task: PublishTestResults@2 | ||
inputs: | ||
testResultsFiles: '**/test-results.xml' | ||
condition: succeededOrFailed() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
trigger: | ||
- master | ||
- releases/* | ||
|
||
jobs: | ||
|
||
# All tasks on Linux | ||
- job: build_all_windows | ||
displayName: Build all tasks (Windows) | ||
pool: | ||
vmImage: vs2017-win2016 | ||
steps: | ||
- template: azure-pipelines-template.yml | ||
|
||
# All tasks on Linux | ||
- job: build_all_linux | ||
displayName: Build all tasks (Linux) | ||
pool: | ||
vmImage: 'Ubuntu 16.04' | ||
steps: | ||
- template: azure-pipelines-template.yml | ||
|
||
# All tasks on macOS | ||
- job: build_all_darwin | ||
displayName: Build all tasks (macOS) | ||
pool: | ||
vmImage: macos-10.13 | ||
steps: | ||
- template: azure-pipelines-template.yml |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be templated so we get a node
8
and a latest stable node build, like the Travis yaml specifies? We don't need to test every version on every platform; but checking both versions in addition to each platform would be nice (I'd check each platform on latest stable and 'nix only for node8
).On a related note: are there any fast build options we can opt in to? Like Travis had a container opt in (sudo: false); from what I understand the new non-preview 'nix images aren't containerized builds anymore. Mostly just curious here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weswigham I updated so that it gives the latest version of 11, unfortunately I don't think the node tool installer can check for the latest major version though (it will automatically bump with minor versions now though). Also, it looks like Windows builds are failing on Node 11, npm install seems to fail, it works fine on node 8 though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://dev.azure.com/TypeScript-TmLanguage/TypeScript-TmLanguage/_build/results?buildId=28&view=logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What python version does the windows 10 vm have installed? Becuase that error looks like a
node-gyp
python version error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the vm be provisioned with python 2 instead of python 3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good call. Updated accordingly and it is no longer failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weswigham when you get a chance would you mind taking a look at this again? I think it should be good to go.