Translation 2 files to Ko #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for the PR! This section of the codebase is owned by @bumkeyy - if they write a comment saying "LGTM" then it will be merged. |
bumkeyy
reviewed
Sep 15, 2020
| @@ -0,0 +1,38 @@ | |||
| //// { compiler: { target: 99 }, order: 1 } | |||
|
|
|||
| // JavaScript를 쓰는 동안 JavaScript에서 표현할 수 있는 숫자의 크기에 | |||
There was a problem hiding this comment.
Suggested change
| // JavaScript를 쓰는 동안 JavaScript에서 표현할 수 있는 숫자의 크기에 | |
| // JavaScript에서 표현할 수 있는 숫자의 크기에 |
bumkeyy
reviewed
Sep 15, 2020
| const maxHighValue = 9007199254740991; | ||
| const maxLowValue = -9007199254740991; | ||
|
|
||
| // 이 숫자보다 수가 하나라도 더 크거나 작으면 |
There was a problem hiding this comment.
Suggested change
| // 이 숫자보다 수가 하나라도 더 크거나 작으면 | |
| // 아래 숫자보다 수가 하나라도 더 크거나 작으면 |
bumkeyy
reviewed
Sep 15, 2020
| 9007199254740994; | ||
| -9007199254740994; | ||
|
|
||
| // 6진수 |
There was a problem hiding this comment.
Suggested change
| // 6진수 | |
| // 16진수 |
bumkeyy
reviewed
Sep 15, 2020
| // | ||
| // https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/BigInt | ||
|
|
||
| // TypeScript는 이제 JavaScript에 유형이 |
There was a problem hiding this comment.
Suggested change
| // TypeScript는 이제 JavaScript에 유형이 | |
| // TypeScript는 이제 JavaScript에 타입이 |
bumkeyy
reviewed
Sep 15, 2020
| // https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/BigInt | ||
|
|
||
| // TypeScript는 이제 JavaScript에 유형이 | ||
| // BigInt 여야 한다는 것을 알리는 접미사 "n"을 추가하는 |
There was a problem hiding this comment.
Suggested change
| // BigInt 여야 한다는 것을 알리는 접미사 "n"을 추가하는 | |
| // BigInt 여야 한다는 것을 알리는 접미사 "n"을 추가하여 |
bumkeyy
reviewed
Sep 15, 2020
| // TypeScript는 이제 JavaScript에 유형이 | ||
| // BigInt 여야 한다는 것을 알리는 접미사 "n"을 추가하는 | ||
| // 2^52(양수/음수) 이상의 숫자 리터럴에 대한 | ||
| // 숫자 리터럴을 위한 기능을 제공할 것입니다. |
There was a problem hiding this comment.
Suggested change
| // 숫자 리터럴을 위한 기능을 제공할 것입니다. | |
| // 기능을 제공합니다. |
고생하셨습니다 👍 |
|
많은 조언 감사합니다! 의견 주신대로 수정하였습니다. 시간 날 때 확인 부탁드립니다. @bumkeyy |
|
LGTM |
|
Merging because @bumkeyy is a code-owner of all the changes - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
en:
번역 리뷰 요청합니다 : @yeonjuan @guyeol @dvlprsh
ref #910