Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation 2 file to Ko #1449

Merged
merged 11 commits into from
Jan 30, 2021
Merged

Conversation

yahma25
Copy link
Contributor

@yahma25 yahma25 commented Dec 28, 2020

en :

번역 리뷰 요청합니다 : @yeonjuan @guyeol @dvlprsh
ref : #910

감사합니다. :)

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @bumkeyy - if they write a comment saying "LGTM" then it will be merged.

yahma25 and others added 8 commits January 11, 2021 21:01
…sh Coalescing.ts

Co-authored-by: Kibeom Kwon <kgbum2222@gmail.com>
…sh Coalescing.ts

Co-authored-by: Kibeom Kwon <kgbum2222@gmail.com>
…sh Coalescing.ts

Co-authored-by: Kibeom Kwon <kgbum2222@gmail.com>
…sh Coalescing.ts

Co-authored-by: Kibeom Kwon <kgbum2222@gmail.com>
…sh Coalescing.ts

Co-authored-by: Kibeom Kwon <kgbum2222@gmail.com>
…sh Coalescing.ts

Co-authored-by: Kibeom Kwon <kgbum2222@gmail.com>
…sh Coalescing.ts

Co-authored-by: Kibeom Kwon <kgbum2222@gmail.com>
…sh Coalescing.ts

Co-authored-by: Kibeom Kwon <kgbum2222@gmail.com>
@yahma25
Copy link
Contributor Author

yahma25 commented Jan 11, 2021

@bumkeyy 모두 반영하였습니다.
피드백 감사합니다.
피드백이 있으니 더 공부도 되고 재미있네요 😄

@orta
Copy link
Contributor

orta commented Jan 25, 2021

Poke @bumkeyy looks like this needs a final look over (thanks @yahma25 !)

Otherwise I'll merge this PR at the end of the week, it looks like all feedback was addressed. We're moving these PRs into their own repos re: #1480

@bumkeyy
Copy link
Contributor

bumkeyy commented Jan 30, 2021

@orta
Oh, sorry to check late.
It was too busy to confirm.
I will confirm as much as possible within that date. :)

@bumkeyy
Copy link
Contributor

bumkeyy commented Jan 30, 2021

LGTM

@github-actions
Copy link
Contributor

Merging because @bumkeyy is a code-owner of all the changes - thanks!

@github-actions github-actions bot merged commit 1773560 into microsoft:v2 Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants