Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate locale to ko #968

Merged
merged 1 commit into from
Aug 25, 2020
Merged

translate locale to ko #968

merged 1 commit into from
Aug 25, 2020

Conversation

dididy
Copy link
Contributor

@dididy dididy commented Aug 24, 2020

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @bumkeyy - if they write a comment saying "LGTM" then it will be merged.

Copy link
Contributor

@bumkeyy bumkeyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orta
Copy link
Contributor

orta commented Aug 25, 2020

Looks like the security model around GitHub reviews isn't going to work for the LGTM at the moment, I think I know how it can be improved but for now you can write a comment

@bumkeyy
Copy link
Contributor

bumkeyy commented Aug 25, 2020

Looks like the security model around GitHub reviews isn't going to work for the LGTM at the moment, I think I know how it can be improved but for now you can write a comment

okay 😄

@bumkeyy
Copy link
Contributor

bumkeyy commented Aug 25, 2020

LGTM

@github-actions
Copy link
Contributor

Merging because @bumkeyy is a code-owner of all the changes - thanks!

@github-actions github-actions bot merged commit fea28b5 into microsoft:v2 Aug 25, 2020
@github-actions
Copy link
Contributor

Merging because @bumkeyy is a code-owner of all the changes - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants