Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method snippet completion shouldn't add newline unless followed by another member #46609

Closed
DanielRosenwasser opened this issue Oct 31, 2021 · 1 comment · Fixed by #46737
Closed
Assignees
Labels
Bug A bug in TypeScript Domain: Completion Lists The issue relates to showing completion lists in an editor Fix Available A PR has been opened for this issue

Comments

@DanielRosenwasser
Copy link
Member

interface Greeter {
    greet(name: string): string;
}

class Jeeves implements Greeter {
    constructor() {

    }

    /**/
}

Request completion at /**/, and select greet

Expected

interface Greeter {
    greet(name: string): string;
}

class Jeeves implements Greeter {
    constructor() {

    }

    greet(name: string): string {
        
    }
}

Actual

interface Greeter {
    greet(name: string): string;
}

class Jeeves implements Greeter {
    constructor() {

    }

    greet(name: string): string {
        
    }

}
@andrewbranch andrewbranch added this to the TypeScript 4.5.2 milestone Nov 1, 2021
@andrewbranch andrewbranch added Bug A bug in TypeScript Domain: Completion Lists The issue relates to showing completion lists in an editor Effort: Moderate Requires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual". Help Wanted You can do this labels Nov 1, 2021
@gabritto
Copy link
Member

gabritto commented Nov 2, 2021

I expect fixing this issue to be a bit tricky, so I'm gonna go ahead and start working on it.

@andrewbranch andrewbranch removed Help Wanted You can do this Effort: Moderate Requires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual". labels Nov 2, 2021
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Domain: Completion Lists The issue relates to showing completion lists in an editor Fix Available A PR has been opened for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants