Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extra newline in class member snippet completions #46737

Merged
merged 3 commits into from
Nov 9, 2021
Merged

Fix extra newline in class member snippet completions #46737

merged 3 commits into from
Nov 9, 2021

Conversation

gabritto
Copy link
Member

@gabritto gabritto commented Nov 8, 2021

Fixes #46609.

For now there will always be trailing semicolons at the end of property or signature declarations, but I'm working on fixing that in another PR.

@gabritto gabritto requested a review from andrewbranch November 8, 2021 23:01
@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Nov 8, 2021
@gabritto gabritto requested a review from sandersn November 8, 2021 23:02
@andrewbranch
Copy link
Member

@typescript-bot cherry-pick this to release-4.5

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 9, 2021 •
edited
Loading

Heya @andrewbranch, I've started to run the task to cherry-pick this into release-4.5 on this PR at 67d631c. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Nov 9, 2021
Merged
@typescript-bot
Copy link
Collaborator

Hey @andrewbranch, I've opened #46742 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Nov 9, 2021
@gabritto @typescript-bot
Cherry-pick PR microsoft#46737 into release-4.5
196180a 
Component commits:
74cd7a5 fix extra newline

8df5bef Merge branch 'main' into gabritto/issue46609

67d631c fix test
@gabritto gabritto merged commit e5a6ae3 into main Nov 9, 2021
@gabritto gabritto deleted the gabritto/issue46609 branch November 9, 2021 20:03
andrewbranch pushed a commit that referenced this pull request Nov 9, 2021
@gabritto
Cherry-pick PR #46737 into release-4.5 (#46742)
3278641 
Component commits:
74cd7a5 fix extra newline

8df5bef Merge branch 'main' into gabritto/issue46609

67d631c fix test

Co-authored-by: Gabriela Araujo Britto <gabrielaa@microsoft.com>
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 1, 2021
Closed
mprobst pushed a commit to mprobst/TypeScript that referenced this pull request Jan 10, 2022
@gabritto @mprobst
Fix extra newline in class member snippet completions (microsoft#46737)
7f82811 
* fix extra newline

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@sandersn sandersn Awaiting requested review from sandersn

Assignees

@gabritto gabritto

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method snippet completion shouldn't add newline unless followed by another member
3 participants
@gabritto @andrewbranch @typescript-bot