Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salsa cross TS-JS find all references does not work #6647

Closed
egamma opened this issue Jan 27, 2016 · 2 comments
Closed

Salsa cross TS-JS find all references does not work #6647

egamma opened this issue Jan 27, 2016 · 2 comments
Labels
Fixed A PR has been merged for this issue

Comments

@egamma
Copy link
Member

egamma commented Jan 27, 2016

From @alexandrudima on January 27, 2016 14:38

Testing #2218

producer.js:

/**
 * @param {number} one
 */
exports.hi = function(one) {
    return 5;
}

exports.ciao = 'ciao';

consumer.ts

import * as p from './producer';

class A {
    public something: boolean;
    public foo(): void {}
}

var x = p.ciao;

salsa-ts-js-find-references

Copied from original issue: microsoft/vscode#2457

@billti
Copy link
Member

billti commented Jan 27, 2016

Same (subset) of code path for #6648

@billti billti closed this as completed Jan 27, 2016
@zhengbli
Copy link
Contributor

Should be fixed by #6632

@zhengbli zhengbli added the Fixed A PR has been merged for this issue label Jan 28, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

4 participants