Add assert for unexpected syntaxkind and a conservative temporary fix. #2218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the issue that prompted this fix? |
|
@DanielRosenwasser automated reliability testing caught this, no obvious repro. @vladima Looks like you're right. |
This was referenced Jan 27, 2016
This was referenced Jan 27, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conservative fix for a crash in the navbar and adding instrumentation for a better fix.
TypeError: Unable to get property 'localeCompare' of undefined or null reference
at Anonymous function (:20435:25)
at sortNodes (:20433:17)
at getChildNodes (:20424:17)
at createSourceFileItem (:20639:21)
at createTopLevelItem (:20601:25)
at getItemsWorker (:20491:21)
at getNavigationBarItems (:20379:13)
at getNavigationBarItems (:26732:13)
at Anonymous function (:28077:17)
at simpleForwardCall (:27843:9)
at forwardJSONCall (:27857:13)
at forwardJSONCall (:27888:13)
at getNavigationBarItems (:28076:13)