Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salsa could show warning messages on require statements if it is not configured with a module system #6669

Closed
egamma opened this issue Jan 27, 2016 · 3 comments
Assignees
Labels
By Design Deprecated - use "Working as Intended" or "Design Limitation" instead

Comments

@egamma
Copy link
Member

egamma commented Jan 27, 2016

From @alexandrudima on January 27, 2016 10:36

Testing #2218

I don't have a jsconfig.json

image

Copied from original issue: microsoft/vscode#2426

@billti
Copy link
Member

billti commented Jan 27, 2016

This is valid CommonJS/Node code and doesn't need to be compiled/transpiled. It seems reasonable this should just work without a config file.

@alexdima
Copy link
Member

@billti The reason I filed this is because from the past, I have noticed many users do not even realize they need to create a jsconfig.json file to get good language support. And many folks don't read the documentation so they just jump in without a jsconfig.json file and see that cross-file suggestions don't work. Would be nice if we have a path to guide them towards adding it...

@billti
Copy link
Member

billti commented Jan 29, 2016

We're looking into making the defaults (with or without a config file) work as part of #6690. If we switch to 'commonjs' by default, this issue should evaporate.

EDIT: We just agreed to make CommonJS the default if not specified.

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
By Design Deprecated - use "Working as Intended" or "Design Limitation" instead
Projects
None yet
Development

No branches or pull requests

4 participants