Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salsa formatting gives overlapping edits in this case #6666

Closed
egamma opened this issue Jan 27, 2016 · 3 comments
Closed

Salsa formatting gives overlapping edits in this case #6666

egamma opened this issue Jan 27, 2016 · 3 comments
Labels
Bug A bug in TypeScript Domain: Formatter The issue relates to the built-in formatter VS Code Tracked There is a VS Code equivalent to this issue
Milestone

Comments

@egamma
Copy link
Member

egamma commented Jan 27, 2016

From @alexandrudima on January 27, 2016 10:57

Testing #2218

function a1() {
        try {
                        throw new Error('x');         } catch(x) {}
}

Right click > Format

Observe in the developer console. This happens when the passed in edits are invalid or overlap (touch):
image

Copied from original issue: microsoft/vscode#2435

@billti
Copy link
Member

billti commented Jan 27, 2016

@vladima @zhengbli Same as prior issue. Is this Salsa specific, or does TypeScript exhibit this also?

@zhengbli
Copy link
Contributor

FYI I saw this problem on .ts files too.

@billti billti removed the Salsa label Jan 28, 2016
@billti billti modified the milestones: TypeScript 2.0, Salsa 0.9 Jan 28, 2016
@billti billti added the Bug A bug in TypeScript label Jan 28, 2016
@mhegazy mhegazy assigned zhengbli and unassigned egamma Feb 24, 2016
@zhengbli zhengbli added the Domain: Formatter The issue relates to the built-in formatter label Mar 1, 2016
@mhegazy mhegazy modified the milestones: TypeScript 2.1, Future Sep 29, 2016
@mhegazy mhegazy added the VS Code Tracked There is a VS Code equivalent to this issue label Dec 16, 2016
@mjbvz
Copy link
Contributor

mjbvz commented Nov 9, 2022

Just tested in VS Code 1.74 and this seems to be working fine now

@mjbvz mjbvz closed this as completed Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Domain: Formatter The issue relates to the built-in formatter VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Development

No branches or pull requests

5 participants