getFirstToken returns jsdoc as single comment #13599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit odd, but it's the way that 2.0 and earlier behaved. 2.1 broke it.
mhegazy
approved these changes
Jan 20, 2017
| it("gets jsdoc", () => { | ||
| const first = ts.createSourceFile("foo.ts", "/** comment */var a = true;", ts.ScriptTarget.ES5, /*setParentNodes*/ true); | ||
| assert.isDefined(first); | ||
| assert.equal(first.kind, 263); |
There was a problem hiding this comment.
Why does this not use ts.SyntaxKind?
There was a problem hiding this comment.
Oops. I grabbed 263 straight from the debugger. Nice catch. It looks like this issue needs some more attention (to fix getNextToken as well) so I'll correct this in the followup PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13519
This is a bit odd, but it's the way that 2.0 and earlier behaved. 2.1 broke it with the jsdoc parser rewrite.
Also update
LastJSDocNodesince it had fallen out of date.