Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getFirstToken skips JSDoc #13645

Merged
merged 1 commit into from
Jan 24, 2017
Merged

getFirstToken skips JSDoc #13645

merged 1 commit into from
Jan 24, 2017

Conversation

sandersn
Copy link
Member

Fixes #13519.

This is a better fix than #13599 because (1) it behaves like 2.0 (2) jsdoc should generally not be treated as tokens unless it is specifically requested.

Also fixes broken tests associated with #13599.

@sandersn
getFirstToken skips JSDoc
053b3cd 
Fixes #13519.
This is a better fix than #13599.
Also fixes broken tests associated with #13599.
@sandersn
Copy link
Member Author

@mhegazy can you look at this PR? It's a better fix for #13519 where eslint was trying to consume the parse tree using getFirstToken/findNextToken.

@DanielRosenwasser
Copy link
Member

👍

@sandersn sandersn merged commit c1181ae into master Jan 24, 2017
@sandersn sandersn deleted the getFirstToken-skips-jsdoc branch January 24, 2017 16:55
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhegazy mhegazy mhegazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request for info on jsDoc Node addition in TypeScript 2.1.x
4 participants
@sandersn @DanielRosenwasser @mhegazy @msftclas