Lint for fallthrough in switch #14886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/compiler/checker.ts
Outdated
| @@ -3623,7 +3625,8 @@ namespace ts { | |||
| // Private/protected properties/methods are not visible | |||
| return false; | |||
| } | |||
| // Public properties/methods are visible if its parents are visible, so const it fall into next case statement | |||
| // Public properties/methods are visible if its parents are visible, so | |||
There was a problem hiding this comment.
"falls through" needs to be on its own line for tslint to see it. So the continuation of this comment is on the next line. Added a colon to clarify.
mhegazy
approved these changes
Apr 18, 2017
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be nice to use the compiler option for this, but that must wait on #11051.
Added issue #14885. Other missing
breaksthat seemed more obviously mistakes were added.