This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Remove no-switch-case-fallthrough and no-invalid-this
#2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd rather not remove those rules now. Ideally we would wait until typescript adds the ability to disable such errors: microsoft/TypeScript#11051 Keeping those rules around doesn't add much (if any) additional maintenance burden, so I don't see a reason to rush on removing them. In addition, typescript will eventually start using |
|
fair enough, I didn't realize the TS team is using no-switch-case-fall-through. @nchen63 let's keep the rules around and just remove |
|
done in #2424 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1861
CHANGELOG.md entry:
[removed-rule]
no-switch-case-fallthrough: use tsc switch--noFallthroughCasesInSwitchinstead[removed-rule]
no-invalid-this: use tsc switch--noImplicitThisinstead[recommended-removed]
switch-defaultremoved from recommended rule set