Extend from tslint:latest #19309
Extend from tslint:latest #19309
Conversation
ghost
force-pushed
the
tslint_recommended
branch
2 times, most recently
from
bf3b88b to
f1771bb
Compare
ghost
force-pushed
the
tslint_recommended
branch
from
f1771bb to
525a528
Compare
ghost
mentioned this pull request
tslint.json
Outdated
| "variable-name": false, | ||
|
|
||
| // https://github.com/Microsoft/TypeScript/issues/18340 | ||
| "align": false, |
There was a problem hiding this comment.
these seem to be too pedantic and not much value..
There was a problem hiding this comment.
This should be fixed by a formatter instead of by a human.
tslint.json
Outdated
| // TODO | ||
| "arrow-parens": false, // [true, "ban-single-arg-parens"] | ||
| "arrow-return-shorthand": false, | ||
| "ban-types": false, |
There was a problem hiding this comment.
do not think we will do that one.
There was a problem hiding this comment.
This would prevent us from typing a function as Function, which is unsafe. It also seems to fail on every reference to Symbol since we shadow that, but could be configured to ignore that one.
tslint.json
Outdated
| "arrow-parens": false, // [true, "ban-single-arg-parens"] | ||
| "arrow-return-shorthand": false, | ||
| "ban-types": false, | ||
| "callable-types": false, |
There was a problem hiding this comment.
why have this rule at all?
tslint.json
Outdated
| "ban-types": false, | ||
| "callable-types": false, | ||
| "forin": false, | ||
| "interface-name": false, // [true, "never-prefix"], |
There was a problem hiding this comment.
this is going to be hard in the LS, unless we are willing to break some APIs
tslint.json
Outdated
| "forin": false, | ||
| "interface-name": false, // [true, "never-prefix"], | ||
| "member-access": false, // [true, "no-public"] | ||
| "no-angle-bracket-type-assertion": false, |
There was a problem hiding this comment.
There is a lint rule mandating that only that kind of type assertion may be used, should we use that instead?
There was a problem hiding this comment.
No; I'm of the opinion that we should only use as casts since they're the only style that works in all language variants ;)
Also angle brackets are sharp and pointy.
tslint.json
Outdated
| "no-unnecessary-initializer": false, | ||
| "no-var-requires": false, | ||
| "object-literal-key-quotes": false, | ||
| "one-variable-per-declaration": false, |
ghost
force-pushed
the
tslint_recommended
branch
from
aeb3a81 to
73aa04f
Compare
ghost
force-pushed
the
tslint_recommended
branch
from
73aa04f to
79b9156
Compare
We've been ignoring the majority of lint rules and it looks like they'll unearth a lot of bad code. I'm leaving them as TODOs for now but this would get us started down the path of following tslint's recommendations.