Switch the pretty output to use colons to separate file:line:char so that lines are clickable in terminals

[orta]

When tsc, with pretty enabled, gives an error messages they look like this:

source/commands/init/state-setup.ts(21,40): error TS2339: Property 'bold' does not exist on type 'typeof "/Users/orta/dev/projects/danger/danger-js/node_modules/chalk/types/index"'.

21     header: (msg: String) => say(chalk.bold("\n## " + msg + "\n")),

You cannot directly click onsource/commands/init/state-setup.ts(21,40): to jump directly to the line of code, which is ideal. The format, by convention, for that syntax is file:line:char - which this PR switches the message format to.

For example, most testing libraries will output in this format (though I think this just comes from node's exception handling, but you get the point)

---

I couldn't find an issue for this, happy to write one up, but it seemed simple enough to just write a PR instead.

[thetrompf]

Actually the current format is clickable inside VScode, but this way it works both in sublime and atom. Unfortunately I cannot verify if this works in VSCode tonight, maybe someone else can verify it?

[orta]

It does, yes:

[thetrompf]

Cool! Carry on then :)

[DanielRosenwasser]

@mjbvz @billti @mhegazy --pretty output was never meant to be parsed, but do VS/VS Code use it for anything right now?

[DanielRosenwasser]

Sorry, the baselines are now out of date because I just merged in #20416.

[mjbvz]

@DanielRosenwasser The VS Code TS extension doesn't use --pretty

[orta]

Cool - that should be it updated & rebased 👍

[billti]

VS doesn't appear to use that option.

[mhegazy]

thanks @orta! and sorry for the delay.

[orta]

You're welcome, it was over the holidays, so low expectation 👍