Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Use colons for error reporting for lines/char instead on brackets #3861

Closed
orta opened this issue Apr 28, 2018 · 1 comment
Closed

Use colons for error reporting for lines/char instead on brackets #3861

orta opened this issue Apr 28, 2018 · 1 comment

Comments

@orta
Copy link
Contributor

orta commented Apr 28, 2018

Bug Report

  • TSLint version: 5.9.1
  • TypeScript version: 2.8.x
  • Running TSLint via: CLI / VSCode

Links to the error can't be clicked in the terminal due to un-standard URLs

screen shot 2018-04-28 at 5 13 19 pm

I'd love to move them to use the format file.ts:12:3 which matches how TypeScript shows these errors microsoft/TypeScript#20736 (and how test runners show it)

I'm happy to write this PR, but with 79 open PRs, I thought it'd be more prudent to do an issue before putting the time in 👯

TypeScript code being linted

n/a

Actual behavior

~/dev/projects/danger/peril plugins*
❯ yarn lint
yarn run v1.5.1
$  tslint source/**/**/**.ts

ERROR: source/api/_tests/fixtureAPI.ts[20, 1]: Use of default exports is forbidden
ERROR: source/api/pr/dsl.ts[62, 8]: Use of default exports is forbidden
ERROR: source/github/events/github_runner.ts[227, 8]: Use of default exports is forbidden

error An unexpected error occurred: "Command failed.

Expected behavior

~/dev/projects/danger/peril plugins*
❯ yarn lint
yarn run v1.5.1
$  tslint source/**/**/**.ts

ERROR: source/api/_tests/fixtureAPI.ts:20:1 - Use of default exports is forbidden
ERROR: source/api/pr/dsl.ts:62:8 - Use of default exports is forbidden
ERROR: source/github/events/github_runner.ts:227:8 - Use of default exports is forbidden

error An unexpected error occurred: "Command failed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants