Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Used colons for separating the line and character number in prose formatter #4222

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Used colons for separating the line and character number in prose formatter #4222

merged 1 commit into from
Nov 5, 2018

Conversation

reduckted
Copy link
Contributor

PR checklist

Overview of change:

Changed the prose formatter to use the format:

file:line:column - message

instead of:

file[line, column]: message

Is there anything you'd like reviewers to focus on?

Nope.

CHANGELOG.md entry:

[enhancement] prose formatter uses line:column instead of [line, column]

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple, clean, and approved in theory by giladgray. LGTM!

Thanks for this!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 0172fab into palantir:master Nov 5, 2018
@reduckted reduckted deleted the 3861-use-colons-for-line-char-in-prose-formatter branch December 30, 2018 11:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants