[WIP] Remove unnecessary weak types when reporting errors #25145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… whole) types when reporting errors. Summary: When a source type still isn't assignable to an intersection with all the weak types removed, we can generally assume that the "strong" types are the ones that are more interesting to report on. As an improvement, we try to keep them around and remove weak types which we believe will cause noise.
DanielRosenwasser
force-pushed
the
strongTypesForLargeErrors
branch
from
d65fb96
to
7054e73
Compare
| @@ -0,0 +1,96 @@ | |||
| tests/cases/compiler/errorsOnWeakTypeIntersectionTargets01.ts(10,12): error TS2322: Type '{ a: number; b: number; }' is not assignable to type 'A & B'. | |||
| Type '{ a: number; b: number; }' is not assignable to type 'B'. | |||
| Type '{ a: number; b: number; }' is not assignable to type 'B'. | |||
There was a problem hiding this comment.
This seems bad.
DanielRosenwasser
changed the title
|
Closing for housekeeping 🧹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore for now - I've made some changes that actually make errors worse.
Fixes #24146.When a source type still isn't assignable to an intersection with all the weak types removed, we can generally assume that the "strong" types are the ones that are more interesting to report on. As an improvement, we try to keep them around and remove weak types which we believe will cause noise.While this sometimes has undesirable effects when there are incompatibilities among strong types and weak types, this by and large gives better behavior when dealing with types like JSX'sIntrinsicAttributes.