Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Remove unnecessary weak types when reporting errors #25145

Closed
wants to merge 4 commits into from
Closed

[WIP] Remove unnecessary weak types when reporting errors #25145

wants to merge 4 commits into from

Commits on Jun 22, 2018

  1. Added test.

    @DanielRosenwasser
    DanielRosenwasser committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    b94fd85 View commit details
    Browse the repository at this point in the history

  2. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    007d28d View commit details
    Browse the repository at this point in the history

  3. Avoid printing out useless weak (but still important for society as a… 

    … whole) types when reporting errors.

Summary: When a source type still isn't assignable to an intersection with all the weak types removed,
we can generally assume that the "strong" types are the ones that are more interesting to report on.
As an improvement, we try to keep them around and remove weak types which we believe will cause noise.
    @DanielRosenwasser
    DanielRosenwasser committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    a001ab5 View commit details
    Browse the repository at this point in the history

  4. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    7054e73 View commit details
    Browse the repository at this point in the history