Skip to content

Do not erase signatures in getSignatureOfTypeTag #43688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

sandersn
Copy link
Member

Introduced in #26236, but with no tests.

Fixes #42060

I don't see a reason for it, and it doesn't cause any tests to fail.
@sandersn
Copy link
Member Author

@typescript-bot user test this

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Apr 15, 2021
@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 15, 2021

Heya @sandersn, I've started to run the parallelized community code test suite on this PR at 04613a6. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@sandersn
Copy link
Member Author

User tests are clean.

@sandersn sandersn merged commit 0987ee9 into master Apr 15, 2021
@sandersn sandersn deleted the no-erasure-of-type-tag-signatures branch April 15, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In JS, @type tag doesn't apply generic type to initialiser
3 participants