Skip to content

Do not erase signatures in getSignatureOfTypeTag #43688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/compiler/checker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12182,8 +12182,7 @@ namespace ts {
// should be attached to a function declaration or expression
if (!(isInJSFile(node) && isFunctionLikeDeclaration(node))) return undefined;
const typeTag = getJSDocTypeTag(node);
const signature = typeTag && typeTag.typeExpression && getSingleCallSignature(getTypeFromTypeNode(typeTag.typeExpression));
return signature && getErasedSignature(signature);
return typeTag?.typeExpression && getSingleCallSignature(getTypeFromTypeNode(typeTag.typeExpression));
}

function getReturnTypeOfTypeTag(node: SignatureDeclaration | JSDocSignature) {
Expand Down
14 changes: 14 additions & 0 deletions tests/baselines/reference/typeTagNoErasure.errors.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
tests/cases/conformance/jsdoc/typeTagNoErasure.js(7,6): error TS2345: Argument of type 'string' is not assignable to parameter of type 'number'.


==== tests/cases/conformance/jsdoc/typeTagNoErasure.js (1 errors) ====
/** @template T @typedef {<T1 extends T>(data: T1) => T1} Test */

/** @type {Test<number>} */
const test = dibbity => dibbity

test(1) // ok, T=1
test('hi') // error, T=number
~~~~
!!! error TS2345: Argument of type 'string' is not assignable to parameter of type 'number'.

23 changes: 23 additions & 0 deletions tests/baselines/reference/typeTagNoErasure.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
//// [typeTagNoErasure.js]
/** @template T @typedef {<T1 extends T>(data: T1) => T1} Test */

/** @type {Test<number>} */
const test = dibbity => dibbity

test(1) // ok, T=1
test('hi') // error, T=number


//// [typeTagNoErasure.js]
/** @template T @typedef {<T1 extends T>(data: T1) => T1} Test */
/** @type {Test<number>} */
var test = function (dibbity) { return dibbity; };
test(1); // ok, T=1
test('hi'); // error, T=number


//// [typeTagNoErasure.d.ts]
/** @template T @typedef {<T1 extends T>(data: T1) => T1} Test */
/** @type {Test<number>} */
declare const test: Test<number>;
type Test<T> = <T1 extends T>(data: T1) => T1;
15 changes: 15 additions & 0 deletions tests/baselines/reference/typeTagNoErasure.symbols
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
=== tests/cases/conformance/jsdoc/typeTagNoErasure.js ===
/** @template T @typedef {<T1 extends T>(data: T1) => T1} Test */

/** @type {Test<number>} */
const test = dibbity => dibbity
>test : Symbol(test, Decl(typeTagNoErasure.js, 3, 5))
>dibbity : Symbol(dibbity, Decl(typeTagNoErasure.js, 3, 12))
>dibbity : Symbol(dibbity, Decl(typeTagNoErasure.js, 3, 12))

test(1) // ok, T=1
>test : Symbol(test, Decl(typeTagNoErasure.js, 3, 5))

test('hi') // error, T=number
>test : Symbol(test, Decl(typeTagNoErasure.js, 3, 5))

20 changes: 20 additions & 0 deletions tests/baselines/reference/typeTagNoErasure.types
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
=== tests/cases/conformance/jsdoc/typeTagNoErasure.js ===
/** @template T @typedef {<T1 extends T>(data: T1) => T1} Test */

/** @type {Test<number>} */
const test = dibbity => dibbity
>test : Test<number>
>dibbity => dibbity : <T1 extends number>(dibbity: T1) => T1
>dibbity : T1
>dibbity : T1

test(1) // ok, T=1
>test(1) : 1
>test : Test<number>
>1 : 1

test('hi') // error, T=number
>test('hi') : number
>test : Test<number>
>'hi' : "hi"

11 changes: 11 additions & 0 deletions tests/cases/conformance/jsdoc/typeTagNoErasure.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
// @checkJs:true
// @declaration: true
// @outdir: out/
// @filename: typeTagNoErasure.js
/** @template T @typedef {<T1 extends T>(data: T1) => T1} Test */

/** @type {Test<number>} */
const test = dibbity => dibbity

test(1) // ok, T=1
test('hi') // error, T=number