-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically create sort groups based on newlines in organize imports #48330
Automatically create sort groups based on newlines in organize imports #48330
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
ff8df38
to
b89f697
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks about right to me, but I think what I'd like to see are a few more tests to cover cases where there are comments, e.g., what is the behavior when we have something like:
// polyfill
import "lib"
// not polyfill
import { b } from "lib2"
or say
import "lib" // xyz
import c from "C"
Or similar (this isn't exhaustive). I know the original issue had some code snippets that feature comments.
fd96817
to
2c13fec
Compare
aa759f0
to
24e4cd9
Compare
f594067
to
bd8ce22
Compare
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Closes #41494.
Based on @RyanCavanaugh's suggestion #41494 (comment)
when organizing imports in each block of newline-contiguous
turns into