-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Automatically create sort groups based on newlines in organize imports #48330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jakebailey
merged 9 commits into
microsoft:main
from
MQuy:feature/create-sort-groups-by-newlines
Apr 5, 2022
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b89f697
Create sort groups based on newlines
ef6c7db
Update ambient module test to match with new sort groups
fa83bce
Use for of to make code shorter and shorten argument
141f9ee
Sort import based on newlin eand comments
c22b697
Add import group tests for newline and comments
2c13fec
Remove SortComments test and fix organizeImport6
bd8ce22
Rename isNewGroup and reuse scanner
eee44b5
Update src/services/organizeImports.ts
MQuy f61a657
Fix code format
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
tests/cases/fourslash/organizeImportsGroup_CommentInNewline.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
/// <reference path="fourslash.ts" /> | ||
|
||
////// polyfill | ||
////import c from "C"; | ||
////// not polyfill | ||
////import d from "D"; | ||
////import a from "A"; | ||
////import b from "B"; | ||
//// | ||
////console.log(a, b, c, d) | ||
|
||
verify.organizeImports( | ||
`// polyfill | ||
import c from "C"; | ||
// not polyfill | ||
import a from "A"; | ||
import b from "B"; | ||
import d from "D"; | ||
|
||
console.log(a, b, c, d)` | ||
); |
21 changes: 21 additions & 0 deletions
21
tests/cases/fourslash/organizeImportsGroup_MultiNewlines.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
/// <reference path="fourslash.ts" /> | ||
|
||
////import c from "C"; | ||
//// | ||
//// | ||
jakebailey marked this conversation as resolved.
Show resolved
Hide resolved
|
||
////import d from "D"; | ||
////import a from "A"; | ||
////import b from "B"; | ||
//// | ||
////console.log(a, b, c, d) | ||
|
||
verify.organizeImports( | ||
`import c from "C"; | ||
|
||
|
||
import a from "A"; | ||
import b from "B"; | ||
import d from "D"; | ||
|
||
console.log(a, b, c, d)` | ||
); |
25 changes: 25 additions & 0 deletions
25
tests/cases/fourslash/organizeImportsGroup_MultilineCommentInNewline.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
/// <reference path="fourslash.ts" /> | ||
|
||
////// polyfill | ||
////import c from "C"; | ||
/////* | ||
////* demo | ||
////*/ | ||
////import d from "D"; | ||
////import a from "A"; | ||
////import b from "B"; | ||
//// | ||
////console.log(a, b, c, d) | ||
|
||
verify.organizeImports( | ||
`// polyfill | ||
import c from "C"; | ||
/* | ||
* demo | ||
*/ | ||
import a from "A"; | ||
import b from "B"; | ||
import d from "D"; | ||
|
||
console.log(a, b, c, d)` | ||
); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
/// <reference path="fourslash.ts" /> | ||
|
||
////import c from "C"; | ||
//// | ||
////import d from "D"; | ||
////import a from "A"; // not count | ||
////import b from "B"; | ||
//// | ||
////console.log(a, b, c, d) | ||
|
||
verify.organizeImports( | ||
`import c from "C"; | ||
|
||
import a from "A"; // not count | ||
import b from "B"; | ||
import d from "D"; | ||
|
||
console.log(a, b, c, d)` | ||
); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.