Skip to content

Make getSupportedCodeFixes plugin test such that we dont need to update its baseline for every new error #52596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sheetalkamat merged 1 commit into from
Feb 3, 2023
Merged

Make getSupportedCodeFixes plugin test such that we dont need to update its baseline for every new error #52596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/testRunner/unittests/tsserver/plugins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,8 @@ describe("unittests:: tsserver:: plugins overriding getSupportedCodeFixes", () =
case "/b.ts":
return ["b"];
default:
return info.languageService.getSupportedCodeFixes(fileName);
// Make this stable list of single item so we dont have to update the baseline for every additional error
return [info.languageService.getSupportedCodeFixes(fileName)[0]];
Copy link
Member

@jakebailey jakebailey Feb 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we happen to change what supported code fix comes first, will this also change? Maybe that's unlikely...

Copy link
Member Author

@sheetalkamat sheetalkamat Feb 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep thats probably a rare one compared to now when we have to update this everytime.

}
};
return proxy;
Expand Down
Loading