Make getSupportedCodeFixes plugin test such that we dont need to update its baseline for every new error #52596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te its baseline for every new error
typescript-bot
added
Author: Team
For Uncommitted Bug
|
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @mjbvz, @zkat, and @joj for you. Feel free to loop in other consumers/maintainers if necessary |
jakebailey
reviewed
Feb 3, 2023
| default: | ||
| return info.languageService.getSupportedCodeFixes(fileName); | ||
| // Make this stable list of single item so we dont have to update the baseline for every additional error | ||
| return [info.languageService.getSupportedCodeFixes(fileName)[0]]; |
Member
There was a problem hiding this comment.
If we happen to change what supported code fix comes first, will this also change? Maybe that's unlikely...
Member
Author
There was a problem hiding this comment.
yep thats probably a rare one compared to now when we have to update this everytime.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered that every error needs to update baseline which is not what this test is for so just changed it so we would need baseline update if and only if the first error code changes.