Make getSupportedCodeFixes plugin test such that we dont need to update its baseline for every new error #53070
Conversation
…te its baseline for every new error Take 2
typescript-bot
added
Author: Team
For Uncommitted Bug
| /** @internal */ | ||
| export function getSupportedErrorCodes(): readonly string[] { | ||
| return arrayFrom(errorCodeToFixes.keys()); | ||
| return errorCodeToFixesArray ??= arrayFrom(errorCodeToFixes.keys()); |
There was a problem hiding this comment.
Codefixes are registered at runtime, so if this call happens too early it may get locked in forever with a reduced list.
Can we add something like errorCodeToFixesArray = undefined to registerCodeFix above just to make sure this function is always accurate? It's unlikely, but, seems like it'd be a bit annoying to have to debug if we did accidentally cause this to happen. 😅
(I want to get rid of this registration mechanism at some point, as it's side-effect based and could be redone post-modules, but, that's another change.)
There was a problem hiding this comment.
right now how this is setup is that this is immutable list and is correct when called. I will go ahead and add assert in register code fix though
There was a problem hiding this comment.
You'd be surprised; I know of a few projects which add more on:
There was a problem hiding this comment.
wow .. thats just misusing it.. their plugin instead needs to implement getSupportedCodeFixes on LS
There was a problem hiding this comment.
An assert would stop those cases from functioning, right?
There was a problem hiding this comment.
An assert would stop those cases from functioning, right?
Yeah for now i have just gone ahead with resetting the list.
There was a problem hiding this comment.
To be clear I'm not against breaking this particular mechanism of adding code fixes. I'm curious why they did this; hopefully it was just because they didn't know about getSupportedCodeFixes, but maybe there's a restriction there I'm not thinking of. tsec is one that I think is actively maintained. The roblox one is... confusing because it doesn't add anything.
There was a problem hiding this comment.
The restriction is that IDEs don't use the feature so the function is never called and the proxy is useless. I created an issue: microsoft/vscode#219273
There was a problem hiding this comment.
Isn't making more people depend on this an even worse direction?
There was a problem hiding this comment.
Which direction?
I don't have much opinion on the design, but I think the language server should have an official API to extend code actions.
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
Glad to have these baselines fixed!
Take 2
#52596 still left one request that was not redirected so printing all the error codes.